Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge classes for tpAdd, bgpAdd, and gpAdd #343

Open
hartig opened this issue Jul 5, 2024 · 0 comments
Open

Merge classes for tpAdd, bgpAdd, and gpAdd #343

hartig opened this issue Jul 5, 2024 · 0 comments

Comments

@hartig
Copy link
Member

hartig commented Jul 5, 2024

We have three separate classes for the three logical operators tpAdd, bgpAdd, and gpAdd, and another three classes for the left-outer counterparts ( tpOptAdd, bgpOptAdd, and gpOptAdd). This leads to quite a bit of code duplication in code related to these classes (e.g., in several places we have three if-else branches for them, where such branch does essentially the same thing but after casting to the particular class).

This issue is about merging these classes into two, one for the three inner-join versions (tpAdd, bgpAdd, and gpAdd) and one for the left-join versions (tpOptAdd, bgpOptAdd, and gpOptAdd). There may be some helper methods within the merged classes to be able to quickly ask whether the current graph pattern is a triple pattern/BGP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant