New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config creation/syncing pages #65

Open

legoandmars opened this issue Jan 1, 2024 · 1 comment

Contributor

legoandmars commented Jan 1, 2024 •

edited

Loading

in addition to #56 there are the following issues:

BinaryFormatter has security issues and should not be used, convert to binaryreader/binarywriter
The guide says to make ConfigEntry static by default, which should not be the case and is actively making things more confusing - switch the config class to be singleton pattern
NetworkDelivery.ReliableFragmentedSequenced should be used for larger config files

Contributor Author

legoandmars commented Jan 1, 2024

Not sure if I'll have time to do this myself in the next few days, if anybody can PR i'll merge though

Owen3H mentioned this issue

Improve config creation/syncing guides. #67

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment