Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config option to select min time or vote skip #12

Open
hamishfagg opened this issue Jan 10, 2017 · 4 comments
Open

Config option to select min time or vote skip #12

hamishfagg opened this issue Jan 10, 2017 · 4 comments

Comments

@hamishfagg
Copy link
Contributor

I think some users will probably prefer the old skipping, where anyone can skip after a certain amount of time. It shouldn't be too much work to make this configurable to select between the two.

@Lesterpig
Copy link
Owner

Good idea! But another idea would be too always keep the two options, with something like this:

  • One option to define minimum number of votes (defaults to 3 for example)
  • One option to define amount of play time needed to bypass the vote (defaults to 5 minutes for example)

@hamishfagg
Copy link
Contributor Author

hamishfagg commented Jan 14, 2017

Yeah that's a better idea. So number of votes to skip could be set to 1 to disable it, and min play time could be set to 0 to disable it. Otherwise you could have a combination of both =)

EDIT: What would be the preferred behaviour if (in your example) 3 votes had been reached before 5mins had played?

@Lesterpig
Copy link
Owner

I would say that the first encountered skip condition win.
In that case, we ignore the minimum time and consider that the music should be skipped because we have enough votes.

@oddhorse
Copy link

oddhorse commented Feb 4, 2017

How is this going? I would love to disable the vote-skip system, the skip-after-set-time would be perfect for my use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants