Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a visitor to split insertion of multiple articles #10

Open
Seb35 opened this issue Aug 8, 2018 · 2 comments
Open

Create a visitor to split insertion of multiple articles #10

Seb35 opened this issue Aug 8, 2018 · 2 comments

Comments

@Seb35
Copy link
Member

Seb35 commented Aug 8, 2018

For instance there are 3 articles and 1 title inserted together in http://www.assemblee-nationale.fr/15/textes/0911.asp#D_Article_14.

A visitor should be created to detect such cases and split them into multiple article-definition nodes. In the example given, the name of title XI is also modified and a title-definition should also be created.
@JMLX42
Copy link
Member

JMLX42 commented Aug 8, 2018

AFAIK that's already the case. There is a visitor that will split/fork edit nodes with multiple references/definitions.

@Seb35
Copy link
Member Author

Seb35 commented Aug 9, 2018

Yes, ForkEditVisitor (which btw is not used) but it operates on existing ref+def nodes. Here the case is a single quote in a single def node. The text content should be splitted, and probably ForkEditVisitor will be useful then.

Seb35 added a commit that referenced this issue Dec 23, 2018
@Seb35
Add more checks in RemoveQuotePrefixVisitor
92fbf48 
In particular, check than the removed prefix "Art. {articleId}. -"
is the same than its container article-definition (if this one declared
the article name) and check that the dash in the articleId is the standard
dash (possibly the article-definition nodes could force their id to be a
standard dash).

Also the very last dash in "Art. {articleId}. -" can be any type of
dash between the 7 dashed defined in Unicode.

Also removed the multiline flag, because if there are multiple articles
defined in a single 'word' node, they should be splitted into independant
'article-definition'+'word' nodes (see #10).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Seb35 @JMLX42