Found a BUG that caused the server to crash.[Bug]

[ddk2001]

🐛 Bug report

Found a BUG, in the copy of Blackstone Abyss, boss's creature_template entry： 9018. When the blood hit about 30%, it appeared: unable to attack in escape state. Then the server crashed. At the same time, there are still many tasks that cannot be completed in dialogue with NPC.

• No information

Expected behavior

• No information

Steps to reproduce

4. ...
5. Profit.

Version

Client Version:

• No information

[leelf00]

Ok,I will debug it.

[ddk2001]

Later, I researched it and found out that the problem was that as long as the character was charmed, ran away in fear, transformed into a small animal, etc., the server would go down.

[ddk2001]

Once this quest has started, horseback riding will cause the server to go down. Several places have been found to cause server crashes. Basically, it is down because the character is not controlled.

[leelf00]

quest id?

[ddk2001]

14293

[leelf00]

Can you post crash log?

[ddk2001]

I didn't compile the debug. I'll compile a copy today.

[ddk2001]

When I log in in DeBug mode, this is prompted.

[leelf00]

Any crash logs from logs folder?

[ddk2001]

the release is not Any crash logs from logs folder。can you test it？

[ddk2001]

I'm going to check this debug log on the office computer on Monday.

[ddk2001]

Application Log
Start: Tue Apr 2 10:05:54 2024

---

Assertion Failure - worldserver.exe
Debug assertion failure

Expression: (low.x <= high.x) && (low.y <= high.y) && (low.z <= high.z)
G:\yuanma\4.1ceshi\Legends-of-Azeroth-Pandaria-5.4.8\dep\g3dlite\include\G3D/AABox.h:97

---

Assertion Failure - worldserver.exe
Debug assertion failure

Expression: ! low.isNaN() && ! high.isNaN()
G:\yuanma\4.1ceshi\Legends-of-Azeroth-Pandaria-5.4.8\dep\g3dlite\include\G3D/AABox.h:98

---

Assertion Failure - worldserver.exe
Debug assertion failure

Expression: (low.x <= high.x) && (low.y <= high.y) && (low.z <= high.z)
G:\yuanma\4.1ceshi\Legends-of-Azeroth-Pandaria-5.4.8\dep\g3dlite\include\G3D/AABox.h:97

---

Assertion Failure - worldserver.exe
Debug assertion failure

Expression: ! low.isNaN() && ! high.isNaN()
G:\yuanma\4.1ceshi\Legends-of-Azeroth-Pandaria-5.4.8\dep\g3dlite\include\G3D/AABox.h:98

---

Assertion Failure - worldserver.exe
Debug assertion failure

Expression: (low.x <= high.x) && (low.y <= high.y) && (low.z <= high.z)
G:\yuanma\4.1ceshi\Legends-of-Azeroth-Pandaria-5.4.8\dep\g3dlite\include\G3D/AABox.h:97

---

Assertion Failure - worldserver.exe
Debug assertion failure

Expression: ! low.isNaN() && ! high.isNaN()
G:\yuanma\4.1ceshi\Legends-of-Azeroth-Pandaria-5.4.8\dep\g3dlite\include\G3D/AABox.h:98

---

Assertion Failure - worldserver.exe
Debug assertion failure

Expression: (low.x <= high.x) && (low.y <= high.y) && (low.z <= high.z)
G:\yuanma\4.1ceshi\Legends-of-Azeroth-Pandaria-5.4.8\dep\g3dlite\include\G3D/AABox.h:97

---

Assertion Failure - worldserver.exe
Debug assertion failure

Expression: ! low.isNaN() && ! high.isNaN()
G:\yuanma\4.1ceshi\Legends-of-Azeroth-Pandaria-5.4.8\dep\g3dlite\include\G3D/AABox.h:98

---

Assertion Failure - worldserver.exe
Debug assertion failure

Expression: (low.x <= high.x) && (low.y <= high.y) && (low.z <= high.z)
G:\yuanma\4.1ceshi\Legends-of-Azeroth-Pandaria-5.4.8\dep\g3dlite\include\G3D/AABox.h:97

---

Assertion Failure - worldserver.exe
Debug assertion failure

Expression: ! low.isNaN() && ! high.isNaN()
G:\yuanma\4.1ceshi\Legends-of-Azeroth-Pandaria-5.4.8\dep\g3dlite\include\G3D/AABox.h:98

[ddk2001]

There is only so much for this log file to be recorded. The following error message is not logged.

[leelf00]

Seems gameobject issue

[ddk2001]

I think it's also a matter of roles. Once the play is controlled, the server goes down.

[ddk2001]

Did you test it later? Have you found the reason for the downtime? I took a look at gameobject.cpp. I didn't see anything wrong.

[ddk2001]

Thank you! I'm currently on vacation. I'll try it in about 4 days.

[ddk2001]

I found that your source code has the same bug as pandaria, when you buy more than 200,000 gold coins at one time, the gold will not be deducted.

[leelf00]

Yes.We fork from alexkulya's source and have most same bugs.

[leelf00]

How to reproduce? use battle coin buy gold coins?

[ddk2001]

No, for example, if I buy 2,200 gold coins at one time, the total amount of gold required is 220,000 gold. However, no gold will be deducted. I think it should be an issue with int32 limitations

[ddk2001]

Buy-ins above 2147483647 will not be deducted for gold. This is exactly the upper limit of 32 bits

[leelf00]

I push a commit due to money limit. Try last commit

[ddk2001]

How did you find it. The way I came up with was to change the upper limit of the MAX_MONEY_AMOUNT

[leelf00]

MAX_MONEY_AMOUNT is uint64.

[ddk2001]

Yes, it is 64 bits, and the values can be large.

[leelf00]

The 32bit uint32 limit is caused by code. DB column is also right.

[ddk2001]

You just have to find the specific location.

[ddk2001]

For advice, this version of the item upgrade is only up to level 4, and I remember that the official uniform has level 6 or 8. Do you know how to modify the location.

[leelf00]

Could you find some wowhead or old wiki links for me?

[ddk2001]

I have a wiki here, but I don't think it's very useful. https://warcraft.huijiwiki.com/wiki/%E9%A6%96%E9%A1%B5

[leelf00]

https://wowpedia.fandom.com/wiki/Patch_5.4.8
In MOP, item can upgrade 2 times.

[ddk2001]

I think this source code should have been modified. But I can't find the location where this item was upgraded, and the database hasn't found it either. I think it should be in DBC.