Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core/Missings scripts #129

Closed
wants to merge 8 commits into from
Closed

Core/Missings scripts #129

wants to merge 8 commits into from

Conversation

zTerragor
Copy link
Member

Core/Missings scripts - wow token

@zTerragor
Core/Missings scripts
aef488b 
Core/Missings scripts - wow token
@zTerragor zTerragor added bug Something isn't working Database labels Jan 19, 2023
@zTerragor zTerragor linked an issue Jan 19, 2023 that may be closed by this pull request
🐛 [Bug]Some NPCs not on core or DB #124
Open
@zTerragor
Copy link
Member Author

wow tokens:
ScriptName 'wow_token_1' exists in database, but no core script found! ScriptName 'wow_token_10' exists in database, but no core script found! ScriptName 'wow_token_2' exists in database, but no core script found! ScriptName 'wow_token_5' exists in database, but no core script found!

@zTerragor
Copy link
Member Author

it was originally in the code, but alexYa was removed. but not completely. we have 2 ways to remove completely or or add missing code fragments

leelf00
leelf00 reviewed Jan 19, 2023
View reviewed changes
src/server/scripts/Custom/wow_token.cpp Outdated
@@ -0,0 +1,176 @@
#include "ScriptMgr.h"
#include "GridNotifiersImpl.h"
#include "DatabaseEnv.h" // borrar si no necesitas base de datos
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems not using databases function.

src/server/scripts/Custom/wow_token.cpp Outdated
{
if (player->IsInCombat() || player->InArena() || player->InBattleground()) //Item is not usable in combat, arenas and battlegrounds. This can be modified to your taste.
{
player->GetSession()->SendNotification("You may not use this token whilst you are in combat or present in an arena or battleground.");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think custom message can handler in trinity_string table.

src/server/scripts/Custom/wow_token.cpp Outdated

void AddSC_wow_token() // Add to scriptloader normally
{
new wow_token_1();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe token_1,token_2,token_5,token_10 can handler in onescript.

@zTerragor zTerragor added the enhancement New feature or request label Jan 19, 2023
@alexkulya
Copy link
Collaborator

Isn't this variant easier?
https://github.com/alexkulya/pandaria_5.4.8/blob/master/src/server/scripts/Custom/wow_token.cpp

@leelf00 leelf00 force-pushed the wow-token branch 5 times, most recently from 83fcc06 to 73008fa Compare February 8, 2023 13:58
@leelf00
Change locale text to trinity string
3241447 
Change locale text to trinity string
@leelf00
Copy link

leelf00 commented Feb 10, 2023

This commit already merge into master branch.

@zTerragor zTerragor marked this pull request as ready for review February 10, 2023 10:11
@zTerragor zTerragor closed this Feb 10, 2023
@leelf00 leelf00 deleted the wow-token branch February 20, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leelf00 leelf00 leelf00 left review comments

@fuzionproject fuzionproject fuzionproject approved these changes

Assignees

@leelf00 leelf00

@fuzionproject fuzionproject

@zTerragor zTerragor

Labels
bug Something isn't working Database enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug]Some NPCs not on core or DB
4 participants
@zTerragor @alexkulya @leelf00 @fuzionproject