Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace asciinema.org in all messages when url is set. #16

Open
LegNeato opened this issue Mar 13, 2018 · 3 comments
Open

Replace asciinema.org in all messages when url is set. #16

LegNeato opened this issue Mar 13, 2018 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@LegNeato
Copy link
Owner

LegNeato commented Mar 13, 2018 •
edited
Loading

Users can set a different url in their config or as an env variable: https://asciinema.org/docs/config. We currently support this, but we don't change the hostname in messages to the user. If one is set, we should use the url's hostname rather than hardcoding asciinema.org.
@LegNeato LegNeato added bug Something isn't working good first issue Good for newcomers labels Mar 13, 2018
@rleungx
Copy link
Contributor

rleungx commented Apr 17, 2018

It seems that config-rs can not parse the asciinema's config files. Maybe we need to find another crate or change the config file format.

@LegNeato
Copy link
Owner Author

Ugh, I didn't test and assumed it would work. If rust-cli/config-rs#66 gets fixed, this will be supported. There is also a workaround mentioned though I would prefer to have ini support upstream.

@LegNeato
Copy link
Owner Author

On master I fixed the ini config file parsing by updating config-rs FWIW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LegNeato @rleungx