-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggressive notification about blind signing #665
Comments
Hey @tomasz90 , Thanks for your feedback! This UX has been implemented as we want users to actually understand the risks associated with blind signing. The transaction or message data displayed on the Ledger device should be the only elements being trusted. When the parsing is not possible, users should be aware that whatever the software wallet displays, the Ledger device can't guarantee that they will sign the same data.
You point out exactly the problem, and we're working hard to solve it. I invite you to take a look at the ERC-7730 that we're developing. The aim is to drastically increase the clear signing coverage of dApp contracts in the ecosystem, so that blind signing becomes increasingly rare, since these contracts can be added to the registry so that their methods can be interpreted on Ledger devices. While we are preparing for a first version of this solution to be up and running, we are aware that users who are used to interacting a lot with smart contracts would prefer to have one less screen to validate. Nevertheless, we have already reduced the friction after taking user feedback into account (see #620), and believe that we are striking the right balance. |
I read the beginning of erc-7730, but still dont get it... What if a user signs malicious tx, executes a function having exactly the same 4 bytes signature as standard ex. uniswap router function, but underneath it will be code that only drains tokens? |
Hello @tomasz90, |
Description
I see aggressive notification about blind signing. Why aggressive? Because it is displayed EVERY time when I interact with whatever protocol via metamask or rabby wallet. When I have to click
continue anyway
it almost feel like pain (UI/UX design)Your environment
Ledger Flex
Steps to reproduce
Just connect to rabby wallet and interact with for instance jumper exchange.
Expected behaviour
Option:
This behavior can occur, but user should have at least possibility to disable such screen in settings. User should see icon with exclamation mark on second screen as it is now, and maybe label
blind signing
It will be enough for an aware user to understand that this is blind singing.Minimal option:
If this screen really needs to stay, at least highlight
continue anyway
button instead, making as default option - really it is strangely uncomfortable to click this button now - this is not even looking like a button..Actual behaviour
User every time needs to confirm this. Whats more - back to safety button is highlighted, and it really cause "pain" when user have to click the other option.
The text was updated successfully, but these errors were encountered: