Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of NbglReview #64

Open
dfordivam opened this issue Jul 5, 2024 · 0 comments
Open

Usage of NbglReview #64

dfordivam opened this issue Jul 5, 2024 · 0 comments

Comments

@dfordivam
Copy link

I noticed that the review screen of Stax possibly does not match the guidelines laid out in the design document, regarding showing of bars on top of the "Review ..." message.
In the first review screen the bars are not shown, and the user cannot go back to the first "Review.." screen after they have begun the review process.

image

https://developers.ledger.com/docs/device-app/develop/ui/ledger-stax-display/transactions#presenting-context-with-the-transaction-prompt

This is how the NbglReview looks
https://github.com/LedgerHQ/app-boilerplate-rust/blob/main/tests/snapshots/stax/test_sign_tx_long_tx/00000.png

So I want to clarify is the usage of NbglReview fine as it is currently used in the app-boilerplate-rust app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant