-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Window icon #301
Comments
Protocol specification for Wayland. I am running Wayland and can test this. |
Icons can be stored at one of three paths according to the spec. We should check for the existence of the folders and, should the path exist, copy the Leafish icon there. The folder paths should be checked in the following order:
For Ubuntu, it looks like we can place the icon in |
Does it load the icon based on the window name? |
It's based on the application name if it's placed at one of those directories. For dynamically changing the icon, we will have to wait for winit to add this feature for wayland as it's currently unsupported. |
The required upstream patch was merged here |
Winit still doesn't support setting the icon on Wayland via set_window_icon. It seems like creating a file and copying it to the correct path is the method that most apps are using, although it is possible to handle this with Wayland calls directly, although only in Wayland staging for now |
The text was updated successfully, but these errors were encountered: