Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ip validation #2

Open
ak4t0sh opened this issue May 21, 2019 · 5 comments
Open

ip validation #2

ak4t0sh opened this issue May 21, 2019 · 5 comments

Comments

@ak4t0sh
Copy link

ak4t0sh commented May 21, 2019

IP validation seems too permissive I was able to submit following value.
image
@luukverhoeven
Copy link
Member

Thanks Arnaud for testing the plugin! I will check why this isn't validated correctly.

luukverhoeven added a commit that referenced this issue May 22, 2019
@luukverhoeven
#2 improve ip validation
8eb790f 
Make sure validate ipv4 address is correct, dont allow additional junk.
@luukverhoeven
Copy link
Member

Hi Arnaud, can you revalidate this issue?

@ak4t0sh
Copy link
Author

ak4t0sh commented May 22, 2019

Seems OK with IPv4 but not for IPv6 :)

image

luukverhoeven added a commit that referenced this issue May 22, 2019
@luukverhoeven
#2 improve validating ipv6
e7e711b 
ipv6 validation regex missing some escaping and strictness
@luukverhoeven
Copy link
Member

ipv6 should also work correctly now

@ak4t0sh
Copy link
Author

ak4t0sh commented May 23, 2019

👍 Almost. I still can and invalid data after an IPV6 address ;)
image

luukverhoeven added a commit that referenced this issue Jul 22, 2024
@luukverhoeven
Update #2 improve-js-regex
4ef0d5e
luukverhoeven added a commit that referenced this issue Jul 22, 2024
@luukverhoeven
Update #2 improve-js-regex
258a35b
luukverhoeven added a commit that referenced this issue Jul 22, 2024
@luukverhoeven
Update #2 improve-js-regex
d0ad8d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luukverhoeven @ak4t0sh