Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update api error convention #834

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Update api error convention #834

merged 1 commit into from
Oct 24, 2024
+1 −1

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review October 24, 2024 17:36
@ian-shim ian-shim merged commit ab64077 into Layr-Labs:master Oct 24, 2024
7 checks passed
ian-shim added a commit to ian-shim/eigenda that referenced this pull request Oct 25, 2024
@ian-shim
Update api error convention (Layr-Labs#834)
ecc3a4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cody-littley cody-littley cody-littley approved these changes

@samlaf samlaf samlaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ian-shim @samlaf @cody-littley