Skip to content

Commit

Permalink
refactor: add signature to DispersePaidBlob, rm DispersePaidBlobAuthe…
Browse files Browse the repository at this point in the history
…nticated
  • Loading branch information
hopeyen committed Oct 24, 2024
1 parent 40dedb4 commit 9ed0ed8
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
3 changes: 1 addition & 2 deletions api/clients/disperser_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import (
"github.com/Layr-Labs/eigenda/encoding"
"github.com/Layr-Labs/eigenda/encoding/rs"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/credentials"
"google.golang.org/grpc/credentials/insecure"
)
Expand Down Expand Up @@ -149,7 +148,7 @@ func (c *disperserClient) DisperseBlob(ctx context.Context, data []byte, quorums

// TODO: implemented in subsequent PR
func (c *disperserClient) DispersePaidBlob(ctx context.Context, data []byte, quorums []uint8) (*disperser.BlobStatus, []byte, error) {
return nil, nil, api.NewGRPCError(codes.Unimplemented, "not implemented")
return nil, nil, api.NewErrorInternal("not implemented")
}

func (c *disperserClient) DisperseBlobAuthenticated(ctx context.Context, data []byte, quorums []uint8) (*disperser.BlobStatus, []byte, error) {
Expand Down
2 changes: 1 addition & 1 deletion api/grpc/disperser/disperser.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/proto/disperser/disperser.proto
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ message DisperseBlobReply {
// The request ID generated by the disperser.
// Once a request is accepted (although not processed), a unique request ID will be
// generated.
// Three different DisperseBlobRequests (determined by the hash of the DisperseBlobRequest)
// Two different DisperseBlobRequests (determined by the hash of the DisperseBlobRequest)
// will have different IDs, and the same DisperseBlobRequest sent repeatedly at different
// times will also have different IDs.
// The client should use this ID to query the processing status of the request (via
Expand Down
2 changes: 1 addition & 1 deletion disperser/apiserver/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ func (s *DispersalServer) DisperseBlob(ctx context.Context, req *pb.DisperseBlob
}

func (s *DispersalServer) DispersePaidBlob(ctx context.Context, req *pb.DispersePaidBlobRequest) (*pb.DisperseBlobReply, error) {
return &pb.DisperseBlobReply{}, api.NewGRPCError(codes.Unimplemented, "not implemented")
return nil, api.NewErrorInternal("not implemented")
}

// Note: disperseBlob will internally update metrics upon an error; the caller doesn't need
Expand Down

0 comments on commit 9ed0ed8

Please sign in to comment.