Should we remove support for the old spell equations?

[Xaver-DaRed]

I'd like to know how ppl feel about removing the old USE_OLD_CURE_FORMULA configuration (and any others of the same style) and all assiociated code.
My opinion goes like this...
Points in favor: Less code to maintain and bloat the already bloated code base.
Points against: More work involved for Era servers.

My vote? Nuke.

[Era-Lusiphur]

Until something like the proposed module system is in place, I feel like not putting these kinds of things behind a configuration flag hurts adoption. Adoption suffering hinders contributions, in the form of PRs or even just players banging on the server and finding out what's broken.

That said, I understand the desire to cleanse the codebase of it ASAP.

[TeoTwawki]

this might make an excellent example for said module system too if/when it arrives. enable the module, and the global function gets replaced to run the old calculations.

[gweivyth]

Considering era servers tend to be the most popular ones, seems like removing support for them and making more work for anyone hoping to start one isn't a good way to go. I mean I suppose you could direct those people at us, but obviously there are pros/cons to that as well.

I don't see the harm in leaving it really. Seems like more work to remove than to just do nothing.

[claywar]

I think in this case, this is the perfect example to move over to modules. sol_performance created that possibility, and it's about time we used it.