Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Oredicted Ingredients #97

Open
Krutoy242 opened this issue Jan 3, 2024 · 2 comments
Open

[Feature Request] Oredicted Ingredients #97

Krutoy242 opened this issue Jan 3, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Krutoy242
Copy link

Krutoy242 commented Jan 3, 2024

Please make ingredients in machines using Oredict ingredients instead of fixed item IDs.

Im making big modpack E2E-E that have many mods that adds tech ingredients.

For example, I already have Silicon Wafer from Advanced rocketry with waferSilicon ore key.

image

It would be very handy, if instead of remaking whole recipe, i could just remove siliconWafer oredict from QMD item and give it to AdvRocketry item, so recipe will automatically use correct one.

Now only solution i found is this CraftTweaker script:

mods.qmd.target_chamber.removeRecipeWithInput(<qmd:semiconductor:3>, ((<particle:boron_ion> * 1000000) ^ 600) ~ 2.0);
mods.qmd.target_chamber.addRecipe(
  <ore:waferSilicon>, null, ((<particle:boron_ion> * 1000000) ^ 600) ~ 2.0, <qmd:semiconductor>, null,
  null, null, null, 1000, 1.0, 0
);

Same happens with Tungsten Ingot.

  • Using CraftTweaker I removed ingotTungsten oredict from QMD and JAOPCA's (called contenttweaker here) ingots.
  • Then I added ingotTungsten to EndReborn tungsten ingot.
  • Still, all QMD recipes using old list of oredict, before change.

javaw_v9qH3l6mK2

I suspect that oredict ingredient replaced with list of items before CraftTweaker script, that why oredict changes to it cant be applied.

Same suggestion related to some other outputs.

  • For example, there i pressed shift and OreChunks doesnt have any oredicts, but still used as input and scrolling in JEI as variant.
  • Output wrong too - I have other versions of Salt but only QMD one output here, despite it doesnt have salt oredict.

javaw_3EXe9Xp4gx

@Lach01298
Copy link
Owner

Lach01298 commented Jan 6, 2024

Please make ingredients in machines using Oredict ingredients instead of fixed item IDs.

For almost all recipes this is the case none of the recipes shown don't use Oredict. I will admit the oredic for the silicon wafer should probable be waferSilicon not siliconWafer

I'm currently looking into the other issues about removing oredicts not updating recipes

@Lach01298 Lach01298 added the bug Something isn't working label Jan 6, 2024
@Krutoy242
Copy link
Author

Issue is still actual and fix is appreciated.

For example, right now i suffer that my Fiery Fruit, renamed, reoredicted and retextured from Sulfur Pile still added into Target Chamber.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants