Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird logic of numeration for chapters with certain conditions #790

Closed
5 tasks done
Palloxin opened this issue Oct 1, 2023 · 1 comment
Closed
5 tasks done

Weird logic of numeration for chapters with certain conditions #790

Palloxin opened this issue Oct 1, 2023 · 1 comment
Labels
Bug Something isn't working

Comments

@Palloxin
Copy link
Contributor

Palloxin commented Oct 1, 2023

Steps to reproduce

  1. Find a novel with a source that doesnt provide the numeration of chapters like this novel
    IMG_20231001_163627
  2. Switch to "chapter number"
  3. Find a chapter who has a number in the title
YouCut_20231001_184149526.mp4

Expected behavior

The chapters with a number in the title should have Chapter -1 too AND the number is incorrect since it is merely taken from the title due to a bug.

Actual behavior

chapters of entries of sources that dont provide numeration of chapters with (for example) the title "The 8 wonders of Gugu" (so a number in it) are numerated as Chapter 8.

LNReader version

1.1.17

Android version

Android 8

Device

Huawei p8 lite 2017

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • If this is an issue with a source, I should be opening an issue in the sources repository.
  • I have updated the app to version 1.1.17.
  • I will fill out all of the requested information in this form.
@Palloxin Palloxin added the Bug Something isn't working label Oct 1, 2023
@Palloxin Palloxin changed the title Weird numeration of chapter Weird logic of numeration for chapters with certain conditions Oct 1, 2023
@nyagami
Copy link
Member

nyagami commented Jul 16, 2024

App chapter number parser is not perfect and will never ever be perfect, it can not cover all cases.
Each plugin should provide chapter number to app while parsing novel, if no number found app would use its own parser.

@nyagami nyagami closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants