Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPUBs from Fenrir Translations getting "window.pubfuturetag" #1358

Closed
5 tasks done
lalalasupa0 opened this issue Dec 17, 2024 · 4 comments
Closed
5 tasks done

EPUBs from Fenrir Translations getting "window.pubfuturetag" #1358

lalalasupa0 opened this issue Dec 17, 2024 · 4 comments
Labels
Bug Something isn't working

Comments

@lalalasupa0
Copy link

lalalasupa0 commented Dec 17, 2024

Steps to reproduce

Open source "Fenrir Translations"
Download chapters
Click epub icon and save it somewhere
Open a chapter

Expected behavior

The chapter should only have the text showed in the same LNReader

Actual behavior

All chapters start this way:
window.pubfuturetag = window.pubfuturetag || [];window.pubfuturetag.push({unit: "663dd6d999cc415993a26925", id: "pf-8982-1"})
Chapter 1: <from here onwards all seems alright>

LNReader version

54a3feb

Android version

11

Device

Motorola One 5G

Other details

That window.pubfuturetag thing doesn't appear when opening a chapter in LNReader

It appears where on the website are ads, like

[ad] gets replaced with [window.pubfuturetag]

I confirmed that when I got this other thing:
window.pubfuturetag = window.pubfuturetag || [];window.pubfuturetag.push({unit: "663f070a99cc415993a37135", id: "pf-8990-1"})

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • If this is an issue with a source, I should be opening an issue in the sources repository.
  • I have updated the app to version 2.0.0.
  • I will fill out all of the requested information in this form.
@lalalasupa0 lalalasupa0 added the Bug Something isn't working label Dec 17, 2024
@lalalasupa0 lalalasupa0 changed the title Epubs getting weird element "window.pubfuturetag" EPUBs from Fenrir Translations getting "window.pubfuturetag" Dec 17, 2024
@MrVantes
Copy link

MrVantes commented Dec 18, 2024

  • If this is an issue with a source, I should be opening an issue in the sources repository.

Please open your issue in the right repository and make sure to not create duplicate issues.

@lalalasupa0
Copy link
Author

  • If this is an issue with a source, I should be opening an issue in the sources repository.

Please open your issue in the right repository and make sure to not create duplicate issues.

Since it's a thing with the epub maker itself, I thought it would be more conventional to report it here as it's related to the core of the app, and it may not only happen with that extension too
I do wonder if I should open this there tho

@MrVantes
Copy link

Since the issue appears to stem from the source content, it doesn’t seem to be directly related to the EPUB maker itself. Given that the EPUB maker is imported from an external library, it would be more efficient and appropriate to modify the source content rather than altering the EPUB maker.

I hope this clarifies the confusion.

(Unless a senior contributor says otherwise)

@lalalasupa0
Copy link
Author

Since the issue appears to stem from the source content, it doesn’t seem to be directly related to the EPUB maker itself. Given that the EPUB maker is imported from an external library, it would be more efficient and appropriate to modify the source content rather than altering the EPUB maker.

I hope this clarifies the confusion.

(Unless a senior contributor says otherwise)

Makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants