-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sofroniou-Spaletta-5-3-4 method only #355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steven-Roberts
requested review from
balos1,
gardner48,
cswoodward and
drreynolds
as code owners
October 24, 2023 23:04
balos1
previously approved these changes
Oct 25, 2023
gardner48
previously approved these changes
Oct 25, 2023
drreynolds
previously approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor punctuation fixes, but otherwise this is great.
Co-authored-by: Daniel R. Reynolds <[email protected]>
Steven-Roberts
dismissed stale reviews from drreynolds, gardner48, and balos1
via
October 25, 2023 19:21
92e2274
Co-authored-by: Daniel R. Reynolds <[email protected]>
balos1
previously approved these changes
Oct 25, 2023
gardner48
previously requested changes
Oct 25, 2023
drreynolds
approved these changes
Oct 26, 2023
balos1
approved these changes
Oct 26, 2023
balos1
reviewed
Oct 26, 2023
balos1
dismissed
gardner48’s stale review
October 26, 2023 14:17
Suggestion was applied, not sure why it is not being dismissed.
gardner48
added a commit
that referenced
this pull request
Dec 18, 2023
Only adding the `Sofroniou-Spaletta-5-3-4` method but not changing the defaults like #345 --------- Co-authored-by: Daniel R. Reynolds <[email protected]> Co-authored-by: David Gardner <[email protected]>
balos1
pushed a commit
that referenced
this pull request
Dec 18, 2023
Only adding the `Sofroniou-Spaletta-5-3-4` method but not changing the defaults like #345 --------- Co-authored-by: Daniel R. Reynolds <[email protected]> Co-authored-by: David Gardner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only adding the
Sofroniou-Spaletta-5-3-4
method but not changing the defaults like #345