Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sofroniou-Spaletta-5-3-4 method only #355

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

Steven-Roberts
Copy link
Collaborator

Only adding the Sofroniou-Spaletta-5-3-4 method but not changing the defaults like #345

balos1
balos1 previously approved these changes Oct 25, 2023
@balos1 balos1 added this to the SUNDIALS Next milestone Oct 25, 2023
gardner48
gardner48 previously approved these changes Oct 25, 2023
drreynolds
drreynolds previously approved these changes Oct 25, 2023
Copy link
Collaborator

@drreynolds drreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor punctuation fixes, but otherwise this is great.

CHANGELOG.md Outdated Show resolved Hide resolved
doc/arkode/guide/source/Introduction.rst Outdated Show resolved Hide resolved
Co-authored-by: Daniel R. Reynolds <[email protected]>
balos1
balos1 previously approved these changes Oct 25, 2023
doc/arkode/guide/source/Butcher.rst Outdated Show resolved Hide resolved
@balos1 balos1 requested a review from gardner48 October 26, 2023 14:16
@LLNL LLNL deleted a comment from gardner48 Oct 26, 2023
@balos1 balos1 dismissed gardner48’s stale review October 26, 2023 14:17

Suggestion was applied, not sure why it is not being dismissed.

@balos1 balos1 merged commit 6ae281e into develop Oct 26, 2023
16 checks passed
@balos1 balos1 deleted the feature/Sofroniou-Spaletta-5-3-4 branch October 26, 2023 14:18
@balos1 balos1 removed this from the SUNDIALS v7.0.0 milestone Dec 15, 2023
@balos1 balos1 added this to the SUNDIALS v6.7.0 milestone Dec 15, 2023
gardner48 added a commit that referenced this pull request Dec 18, 2023
Only adding the `Sofroniou-Spaletta-5-3-4` method but not changing the
defaults like #345

---------

Co-authored-by: Daniel R. Reynolds <[email protected]>
Co-authored-by: David Gardner <[email protected]>
balos1 pushed a commit that referenced this pull request Dec 18, 2023
Only adding the `Sofroniou-Spaletta-5-3-4` method but not changing the
defaults like #345

---------

Co-authored-by: Daniel R. Reynolds <[email protected]>
Co-authored-by: David Gardner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants