feat: add ipfsHash helper #713
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sessionSigs: SessionSigsMap; | ||
| debug?: boolean; | ||
| }) => { | ||
| const res = await this.executeJs({ |
There was a problem hiding this comment.
Why were we using a LA for this? Seems like a tremendous overkill
Comment on lines
+689
to
+693
| return throwError({ | ||
| message: 'code is required', | ||
| errorKind: LIT_ERROR.INVALID_PARAM_TYPE.kind, | ||
| errorCode: LIT_ERROR.INVALID_PARAM_TYPE.name, | ||
| }); |
There was a problem hiding this comment.
As this PR is pointing to master (v7) it should be updated to use the new errors
| @@ -2,6 +2,7 @@ import { computeAddress } from '@ethersproject/transactions'; | |||
| import { BigNumber, ethers } from 'ethers'; | |||
| import { joinSignature, sha256 } from 'ethers/lib/utils'; | |||
| import { SiweMessage } from 'siwe'; | |||
| import Hash from 'typestub-ipfs-only-hash'; | |||
There was a problem hiding this comment.
Docs and IDE say it should be imported this way
Suggested change
| import Hash from 'typestub-ipfs-only-hash'; | |
| import * as Hash from 'typestub-ipfs-only-hash'; |
IDE:
No default export found in imported module "typestub-ipfs-only-hash".(import/ default)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ipfs hash library instead of using previously lit action ipfs due to bundling issue.
Note