Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods deletion simplification and fix #1386

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Oct 1, 2024

Fixes a bug when multiple methods are selected for deletion. Moves away from figuring out what to do with branches or nodes in the Action. Instead delegate such tasks to the model/view.

Checklist

If you have write access (otherwise a maintainer will do this for you):

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Oct 1, 2024
@mrvisscher mrvisscher added this to the 2.10.3 milestone Oct 1, 2024
@coveralls
Copy link

Coverage Status

coverage: 54.228% (-0.03%) from 54.26%
when pulling 67de963 on mrvisscher:methods-fix
into 901f39c on LCA-ActivityBrowser:main.

Copy link
Member

@marc-vdm marc-vdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-vdm marc-vdm merged commit 28f6bdf into LCA-ActivityBrowser:main Oct 1, 2024
9 checks passed
@mrvisscher mrvisscher deleted the methods-fix branch November 22, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't delete created method
3 participants