Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sankey calculated only when confirmer #1393

Open
MaximeAgez opened this issue Oct 8, 2024 · 1 comment
Open

Sankey calculated only when confirmer #1393

MaximeAgez opened this issue Oct 8, 2024 · 1 comment
Labels
feature Issues/PRs related to a new feature

Comments

@MaximeAgez
Copy link

Feature request

In my work i have a big database (~200,000 processes) which means that it already takes about 8 minutes for a calculation, then another 8 to 10 minutes for generating a Sankey diagram, which is fine. My problem is that whenever I want to change both process and impact category, I have to generate Sankeys which I do not care about, slowing down my process.
For example, say we start to look at the Sankey for process A and method 1 (5 minutes to generate the Sankey), then I switch to process B and method 1 (5 more minutes), so far so good, nothing to do here I guess. But then now I want to switch to process C and method 2. I first have to select process C and as soon as I select process C the Sankey will be generated for the method selected last (method 1) which I do not care about for process C. And then I switch to method 2.

So, I would suggest relying on the "Calculate" button that is already there in the Sankey to launch the generation of a Sankey, and not generating a new Sankey after only one of either process or method is changed.
I understand this is a very specific problem to my case because if somebody works with ecoinvent it does not matter as much as the Sankey is generated in a few seconds.

@MaximeAgez MaximeAgez added the feature Issues/PRs related to a new feature label Oct 8, 2024
@marc-vdm
Copy link
Member

marc-vdm commented Oct 8, 2024

That makes a lot of sense considering your use case. However, as it's not so common for people to have such large systems, I'm not sure how fast we'll get to this.

In the mean time, you could do the calculation, generate the Sankey and then set the calculation depth to 1, then change to the activity and method you want and then set the calculation depth to what you actually need.

This will of course not be ideal, but I hope it speeds up your workflow in the meantime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issues/PRs related to a new feature
Projects
None yet
Development

No branches or pull requests

2 participants