Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when creating circular exchanges between databases #1353

Open
marc-vdm opened this issue Aug 31, 2024 · 1 comment
Open

Add warning when creating circular exchanges between databases #1353

marc-vdm opened this issue Aug 31, 2024 · 1 comment
Labels
feature Issues/PRs related to a new feature

Comments

@marc-vdm
Copy link
Member

Feature request

Databases can have input exchanges from other databases (whichs adds them to the dependends column for databases)

There is nothing stopping users from creating circular exchanges between databases, making it impossible to use them again outside of that project.

Suppose the following situation:
Database 1 with activity A and B
Database 2 with activity C
Database 3 with activity D

  • User creates an exchange from activity A (db1) to activity C (db2) so far so good
  • User creates an exchange from activity C (db2) to activity B (db1), this is allowed but should give user a warning

The above situation is a problem when user exports both databases and tries to import them. This is a problem because both databases refer to eachother as dependent, so neither can be imported first as the dependency is not in the project yet.

This could be complicated by indirectly creating this circular dependency through n databases, e.g. including activity D from db3.

When trying to create an exchange, AB should check the full database dependency chain and give a warning if user is trying to create a circular dependency. IMO this should still be allowed if user wishes to do this, but they should be informed that their data cannot be imported in other projects anymore.

@marc-vdm marc-vdm added the feature Issues/PRs related to a new feature label Aug 31, 2024
@mrvisscher
Copy link
Collaborator

I think the core of this issue is that we currently do not support importing unlinked exchanges. This is something we should add in the feature as it's an important part of project/database management: giving users the flexibility to later link these exchanges manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issues/PRs related to a new feature
Projects
None yet
Development

No branches or pull requests

2 participants