Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sankey does not show some exchanges #1345

Open
1 task done
simb-sdu opened this issue Aug 19, 2024 · 7 comments
Open
1 task done

Sankey does not show some exchanges #1345

simb-sdu opened this issue Aug 19, 2024 · 7 comments
Labels
bug Issues/PRs related to bugs

Comments

@simb-sdu
Copy link

simb-sdu commented Aug 19, 2024

Updating AB

  • Yes, I have updated AB and still experience this issue

What happened?

for some reason, it appears from the sankey diagram that there are no exchanges in both the windows and technical equipment activites. lets just focus on the technical equipment for now
Screenshot from 2024-08-19 11-41-54

however in brightway, three exchanges shows a significant contribution
image

note that the CUMULATIVE value of the activity is the same in BW and the sankey

Relevant errors

No response

Operating system

Linux/Other (please specify above)

Conda environment

No response

@simb-sdu simb-sdu added the bug Issues/PRs related to bugs label Aug 19, 2024
@simb-sdu
Copy link
Author

calculation depth and increasing cutoff does not help

@simb-sdu
Copy link
Author

but if i do a calculation for the activity alone, (in the same calc. setup) it will show as it should in the sankey??

image

@marc-vdm
Copy link
Member

Hi, I'm not really sure if something is really going wrong here -though I admit that the Sankey is hard to understand-.

In the Sankey, the red arrows show the cumulative impact of the product flow (direct from that process and indirect from all upstream processes involved in producing that product), the boxes show only the direct impact of that process.

In the first and third figure, the direct impact of the process A1-A3_Tech.. is 0%, implying that the process itself has no elementary flows that affect the impact category used. The red arrow shows the same number as Brightway, which is the cumulative impact.

As in your second figure hot water tank production has 44% cumulative impact, I would imagine it should show up if you reduce the cutoff for the first calculation to 2% (as 44% of 5.97% > 2%).

Could you let us know if this helps?

@marc-vdm
Copy link
Member

Closing this issue as stale, feel free to re-open if the problem is not resolved.

@marc-vdm marc-vdm closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2024
@simb-sdu
Copy link
Author

Hi @marc-vdm . Sorry I did not see your reply before now. Changing the cutoff value does not show the hot water tank or other sub-processes. Even changed it to 0.5%, which should definitely shows the hot water tank in the sankey (5.8kg CO2 out of the cumulative 219kg). This is why I suggest that there is a bug.

I cannot find the button to reopen the issue

@simb-sdu
Copy link
Author

note that it works as expected when calculating the A1-A3_Tech.. as an activity alone - but not when A1-A3_Tech.. is an exchange in a bigger product system. The same happens to a few other activities, but I cannot see a pattern

@marc-vdm marc-vdm reopened this Sep 30, 2024
@marc-vdm
Copy link
Member

marc-vdm commented Oct 7, 2024

Hey, I've been looking at this, but can't replicate the problem properly for myself.

Probably a thing you already tried, but did you adjust the calculation depth as well?

We use the exact system you show the Brightway output of, so I wouldn't immediately know why this isn't working here if it is working in Brightway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

No branches or pull requests

2 participants