-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config options to restrict signup on certain platforms #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudokoko
changed the title
feat: add config options to restrict signup on certain platforms
Add config options to restrict signup on certain platforms
Oct 12, 2024
sudokoko
requested changes
Oct 12, 2024
ProjectLighthouse.Servers.GameServer/Controllers/Login/LoginController.cs
Outdated
Show resolved
Hide resolved
ProjectLighthouse.Servers.GameServer/Controllers/Login/LoginController.cs
Outdated
Show resolved
Hide resolved
ProjectLighthouse/Configuration/ConfigurationCategories/AuthenticationConfiguration.cs
Show resolved
Hide resolved
FeTetra
reviewed
Oct 12, 2024
ProjectLighthouse.Servers.GameServer/Controllers/Login/LoginController.cs
Outdated
Show resolved
Hide resolved
Slendy
requested changes
Oct 14, 2024
ProjectLighthouse.Servers.GameServer/Controllers/Login/LoginController.cs
Outdated
Show resolved
Hide resolved
ProjectLighthouse.Servers.GameServer/Controllers/Login/LoginController.cs
Outdated
Show resolved
Hide resolved
Zaprit
force-pushed
the
feature/restrict-signup
branch
from
October 20, 2024 16:33
db99ad8
to
d34e6a7
Compare
Slendy
requested changes
Oct 20, 2024
ProjectLighthouse.Servers.GameServer/Controllers/Login/LoginController.cs
Outdated
Show resolved
Hide resolved
ProjectLighthouse.Servers.GameServer/Controllers/Login/LoginController.cs
Outdated
Show resolved
Hide resolved
sudokoko
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See slendy's review, I have nothing to add to it
Co-authored-by: Josh <[email protected]>
…rojectlighthouse into feature/restrict-signup
Slendy
approved these changes
Nov 2, 2024
Finally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a recent increate in abuse of our platform, I have implemented an option to disallow initial signup from certain platforms. It defaults to allow all signup attempts but can be easily restricted in the config. Also fixes the Qodana warnings in LoginController.cs