Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfwbar application menu crashes Wayfire on FreeBSD #131

Open
elgithubo opened this issue Dec 18, 2023 · 5 comments
Open

sfwbar application menu crashes Wayfire on FreeBSD #131

elgithubo opened this issue Dec 18, 2023 · 5 comments

Comments

@elgithubo
Copy link

If I click any application from sfwbar application menu (i.e. trying to launch it), the whole Wayfire session crashes and I am sent back to the non-graphical prompt.
sfwbar version: 1.0-b13
FreeBSD version: 14.0-RELEASE-p3

@Consolatis
Copy link
Contributor

That very much sounds like a wayfire bug, regardless of any potential issue in sfwbar. No application should be able to crash the compositor.

@elgithubo
Copy link
Author

That's a valid point.
I will open an issue against Wayfire.

@LBCrion
Copy link
Owner

LBCrion commented Dec 18, 2023

This does look like a compositor bug, but it's interesting that it happens in the start menu. Sfwbar shouldn't have any direct interaction with the composition or wayland protocol when you select a menu item. Any interaction should come through gtk+/gtk-layer-shell. I wonder if this happens on a close of an xdg_popup popped up from a layer shell toplevel.

May be worth testing other occurrences of this. I.e. if you right click on a taskbar item and then select any item from a menu, does that crash wayfire as well?

@elgithubo
Copy link
Author

I was about to open a ticket against Wayfire, but then I was unsure if it is an upstream issue or an issue with the FreeBSD port.
Can you test on linux if the issue exist there, too? I have no native Linux installation and Wayland won't run in a VM.

@LBCrion
Copy link
Owner

LBCrion commented Dec 26, 2023

I tested this on linux with wayfire version 0.8.0-4dc014b and reproduced the crash. It looks like the issue is with unmapping an xdg_popup popped from a layer shell surface (in case of sfwbar this is a gtk menu), here's the log I got:
wayfire.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants