-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cross-origin iframes issue v22.0.1 #368
Comments
A previous PR I opened does not have this issue |
The full page redirect is needed, it basically has to do a top level redirect so that we can get out of the app to Shopify for OAuth and then Shopify send the user back to the app afterwards. It's likely something happening with the new way AppBridge is loading. You can see the official PHP app does something similar/ |
The issue could be relying on |
I currently cannot replicate this on the latest version, so can someone else replicate it instead of OP? |
Hi @Kyon147, just chiming in here as I've been going through the process of setting up a new app, and I ran into this issue as well. Link to screenshot - https://share.zight.com/yAugPGZ8 Once we allowed the redirects, the app did load, but we got nothing but the blank screen until that happened. I got the same errors in the console, inspecting everything else, the only thing I noticed that was strange is the "frame ancestors" cache key seemed to be present but virtually empty until I accepted the redirects in chrome and let this work. |
For bug reporting only! If you're posting a feature request or discussion, please ignore.
Expected Behavior
When open the app should load properly.
Current Behavior
When I install the app the first time it works well. But when I try to reaccess the app,
I'm having a cross-origin error with the console. ref: https://chromestatus.com/feature/5851021045661696
Failure Information
This happens in the
fullpage_redirect.blade.php:17
Steps to Reproduce
Please provide detailed steps for reproducing the issue.
Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.
Failure Logs
Please include any relevant log snippets or files here.
The text was updated successfully, but these errors were encountered: