Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross-origin iframes issue v22.0.1 #368

Open
jsalguero94 opened this issue Nov 18, 2024 · 8 comments
Open

cross-origin iframes issue v22.0.1 #368

jsalguero94 opened this issue Nov 18, 2024 · 8 comments
Labels
bug Something isn't working unconfirmed Bug has not been reproduced yet

Comments

@jsalguero94
Copy link

For bug reporting only! If you're posting a feature request or discussion, please ignore.

Expected Behavior

When open the app should load properly.

Current Behavior

When I install the app the first time it works well. But when I try to reaccess the app,
I'm having a cross-origin error with the console. ref: https://chromestatus.com/feature/5851021045661696

Failure Information

This happens in the fullpage_redirect.blade.php:17

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Install the app
  2. open a new tab or a new session
  3. Open the app

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Package Version: v22.0.1
  • Laravel Version: v10.48.23
  • PHP Version: v8.2.24
  • Template Engine: Blade
  • Using a toolset (Docker, Laradock, Vagrant, etc.): Herd

Failure Logs

Please include any relevant log snippets or files here.
cross-origin iframe issue

@jsalguero94 jsalguero94 added bug Something isn't working unconfirmed Bug has not been reproduced yet labels Nov 18, 2024
@jsalguero94
Copy link
Author

A previous PR I opened does not have this issue
#364

@enmaboya
Copy link
Contributor

What needs to be done to cause an error?
Nov-18-2024 20-19-00

@jsalguero94
Copy link
Author

When I installed the app the first time it worked, but when I re-opened the app I got the issue.

I'm on macOS 15.0
It happens to me in

  • Arc 1.69.0 (55816)
    This is my main browser. I tested it using security: no protection and I got the same error.

  • Chrome 130.0.6723.117 (Official Build) (arm64)
    I realized in Chrome I needed to explicitly allow the redirect, otherwise, I get the same error
    image

In Firefox (132.0.2 (aarch64)) I don't get the error

@Kyon147
Copy link
Owner

Kyon147 commented Nov 18, 2024

The full page redirect is needed, it basically has to do a top level redirect so that we can get out of the app to Shopify for OAuth and then Shopify send the user back to the app afterwards.

It's likely something happening with the new way AppBridge is loading.

You can see the official PHP app does something similar/

image

@Kyon147
Copy link
Owner

Kyon147 commented Nov 18, 2024

When I installed the app the first time it worked, but when I re-opened the app I got the issue.

I'm on macOS 15.0 It happens to me in

  • Arc 1.69.0 (55816)
    This is my main browser. I tested it using security: no protection and I got the same error.
  • Chrome 130.0.6723.117 (Official Build) (arm64)
    I realized in Chrome I needed to explicitly allow the redirect, otherwise, I get the same error
    image

In Firefox (132.0.2 (aarch64)) I don't get the error

This was a known issue a while back, I can't remember the solve but there is likely an old issue about it.

@Kyon147
Copy link
Owner

Kyon147 commented Nov 18, 2024

The issue could be relying on open as it needs to have AppBridge v4 loaded which is causing a race condition. I'll revert back this file to use a vanilla approach and see if it happens still.

@Kyon147
Copy link
Owner

Kyon147 commented Dec 4, 2024

I currently cannot replicate this on the latest version, so can someone else replicate it instead of OP?

@aj-adl
Copy link

aj-adl commented Dec 5, 2024

Hi @Kyon147, just chiming in here as I've been going through the process of setting up a new app, and I ran into this issue as well.

Link to screenshot - https://share.zight.com/yAugPGZ8

Once we allowed the redirects, the app did load, but we got nothing but the blank screen until that happened.

I got the same errors in the console, inspecting everything else, the only thing I noticed that was strange is the "frame ancestors" cache key seemed to be present but virtually empty until I accepted the redirects in chrome and let this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed Bug has not been reproduced yet
Projects
None yet
Development

No branches or pull requests

4 participants