From 96e7a300c4edb212e3f3247b939b83d2c7d539db Mon Sep 17 00:00:00 2001 From: Philip Carneiro Date: Wed, 5 Jun 2024 09:32:31 +0100 Subject: [PATCH] remove some todos --- src/commands/serverCommand.ts | 8 ++++++-- src/services/dataSourceEditorProvider.ts | 4 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/commands/serverCommand.ts b/src/commands/serverCommand.ts index 6f642921..4ed1cfb2 100644 --- a/src/commands/serverCommand.ts +++ b/src/commands/serverCommand.ts @@ -32,6 +32,7 @@ import { getInsights, getServerName, getServers, + kdbOutputLog, updateInsights, updateServers, } from "../utils/core"; @@ -337,7 +338,10 @@ export async function executeQuery( window.showErrorMessage( "No active connection found. Connect to one connection.", ); - //TODO ADD ERROR TO CONSOLE HERE + kdbOutputLog( + "No active connection found. Connect to one connection.", + "ERROR", + ); return undefined; } else { connLabel = ext.activeConnection.connLabel; @@ -346,7 +350,7 @@ export async function executeQuery( const isConnected = connMngService.isConnected(connLabel); if (!isConnected) { window.showInformationMessage("The selected connection is not connected."); - //TODO ADD ERROR TO CONSOLE HERE + kdbOutputLog("The selected connection is not connected.", "ERROR"); return undefined; } diff --git a/src/services/dataSourceEditorProvider.ts b/src/services/dataSourceEditorProvider.ts index 7ad1b758..2fed725c 100644 --- a/src/services/dataSourceEditorProvider.ts +++ b/src/services/dataSourceEditorProvider.ts @@ -41,7 +41,7 @@ import { import { InsightsConnection } from "../classes/insightsConnection"; import { MetaObjectPayload } from "../models/meta"; import { ConnectionManagementService } from "./connectionManagerService"; -import { offerConnectAction } from "../utils/core"; +import { kdbOutputLog, offerConnectAction } from "../utils/core"; export class DataSourceEditorProvider implements CustomTextEditorProvider { public filenname = ""; @@ -92,7 +92,7 @@ export class DataSourceEditorProvider implements CustomTextEditorProvider { ); meta = Promise.resolve({}); this.cache.set(connLabel, meta); - //TODO ADD ERROR TO CONSOLE HERE + kdbOutputLog("No database running in this Insights connection.", "ERROR"); } return (await meta) || Promise.resolve({}); }