Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staking cooldown removal #251

Closed
wants to merge 8 commits into from
Closed

Staking cooldown removal #251

wants to merge 8 commits into from

Conversation

Flocqst
Copy link
Contributor

@Flocqst Flocqst commented Jul 2, 2024

Remove the staking cooldown for the stakingv2 contracts.

Description

  • Remove staking cooldown from contracts/StakingRewardsV2.sol, contracts/RewardEscrowV2.sol and contracts/EscrowMigrator.sol
  • Update tests to reflect removal of staking cooldown

Motivation and Context

KIP-127: Staking V2 Upgrade

@Flocqst Flocqst requested a review from jcmonte July 2, 2024 15:04
@Flocqst Flocqst changed the title Staking cooldown Staking cooldown removal Jul 2, 2024
tommyrharper
tommyrharper suggested changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@tommyrharper tommyrharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Flocqst 💪 🔥 🎉 - glad to see this getting ripped out! Left a few comments here and there, nothing major :)

JaredBorders
JaredBorders suggested changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@JaredBorders JaredBorders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preliminary review - just waiting for our sync to go further

test/foundry/unit/StakingRewardsV2/StakingRewardsV2.t.sol Show resolved Hide resolved
@JaredBorders
Copy link
Contributor

please add your name/email/gh handle as author to contracts you modified.

@Flocqst
Copy link
Contributor Author

Flocqst commented Jul 17, 2024

Thanks for the review @tommyrharper, took into account almost every comment you had except for the suggestion i did not include because of the incoming #252.

JaredBorders
JaredBorders approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@JaredBorders JaredBorders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic-wise, everything looks good to me. Nice work 💪

The only point of concern:
Removing the cooldown could potentially lead to governance attacks, depending on the voting mechanism implementation.

For instance, with snapshot voting, a malicious actor could utilize a flashloan to artificially inflate voting power if they knew the exact block of the snapshot. This risk should be documented in the interface or another appropriate location.

tommyrharper
tommyrharper approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@tommyrharper tommyrharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for addressing all my concerns!

@Flocqst Flocqst closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyrharper tommyrharper tommyrharper approved these changes

@JaredBorders JaredBorders JaredBorders approved these changes

@jcmonte jcmonte Awaiting requested review from jcmonte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Flocqst @JaredBorders @tommyrharper