Add auction start functionality to vault #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flocqst
requested changes
Oct 29, 2024
src/KSXVault.sol
Outdated
|
|
||
| /// @notice Starts the auction with the USDC balance of the vault | ||
| /// @param _startingBid The starting bid for the auction | ||
| function createAuction(uint256 _startingBid) public { |
There was a problem hiding this comment.
This should be performed on vault operations (deposit/redeem) when possible so that no one has to call the auction manually.
What you should be doing instead is having a modifier, something like that for instance :
modifier checkAuction() {
if (isAuctionReady()) {
createAuction();
}
_;
}
and add it to the deposit/redeem functions.
src/KSXVault.sol
Outdated
Comment on lines
141
to
142
| /// @notice Starts the auction with the USDC balance of the vault | ||
| /// @param _startingBid The starting bid for the auction |
There was a problem hiding this comment.
_startingBid logic should be handled directly in the auction factory, KSX vault should only have "vault logic" and the logic to start auction. (same as bidBuffer).
src/KSXVault.sol
Outdated
Comment on lines
144
to
146
| if (!isAuctionReady()) { | ||
| revert AuctionNotReady(); | ||
| } |
There was a problem hiding this comment.
You can remove this and make function internal as the check will be performed in the modifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.