Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validating schema definitions #19

Open
KuceraMartin opened this issue Nov 11, 2022 · 1 comment
Open

validating schema definitions #19

KuceraMartin opened this issue Nov 11, 2022 · 1 comment

Comments

@KuceraMartin
Copy link
Owner

Should we allow Table objects to contain arbitrary fields/methods or not?

Currently we throw an exception when an unexpected field is encountered in the QueryBuilderFactory macro. Alternatively, we could just ignore these fields.

If we do want to be strict and only allow fields that translate to scope values, it would be nice if this checking happened at definition time and not when calling from(...). Ideally such that IDEs highlight the specific values in the object that are invalid. Could we somehow do this with macros? It would be cool if we could have a "custom case object", i.e. something like table object MyTable instead of case object MyTable extends Table

@KuceraMartin KuceraMartin added the question Further information is requested label Nov 11, 2022
@KuceraMartin
Copy link
Owner Author

skip for now, later we could rethink whether we can validate at definition time

there was some master's thesis on triggering macros with annotations -> check the status of that

@KuceraMartin KuceraMartin added backlog and removed question Further information is requested labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant