Revert on transient redis error #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsnaps
commented
May 9, 2024
Comment on lines
+179
to
+187
| pub async fn consume<F, Fut, T, E>(&self, max: usize, consumer: F) -> Result<T, E> | ||
| where | ||
| F: FnOnce(HashMap<Counter, Arc<CachedCounterValue>>) -> Fut, | ||
| Fut: Future<Output = O>, | ||
| Fut: Future<Output = Result<T, E>>, |
There was a problem hiding this comment.
This signature is getting somewhat … ugly. But async closures aren't a stable thing yet, so I can't have anything call await in the closure passed to consume… that's how I went about it instead…
alexsnaps
force-pushed
the
revert_on_redis_err
branch
from
500f1bb to
27af568
Compare
alexsnaps
force-pushed
the
revert_on_redis_err
branch
from
27af568 to
994a994
Compare
alexsnaps
force-pushed
the
revert_on_redis_err
branch
2 times, most recently
from
57712fd to
6616811
Compare
alexsnaps
force-pushed
the
revert_on_redis_err
branch
from
6616811 to
59a9f85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #297
Based off #318 …