Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async fn flush_batcher_and_update_counters drops pending writes on partition #297

Closed
alexsnaps opened this issue Apr 24, 2024 · 0 comments · Fixed by #319
Closed

async fn flush_batcher_and_update_counters drops pending writes on partition #297

alexsnaps opened this issue Apr 24, 2024 · 0 comments · Fixed by #319
Labels
kind/bug Something isn't working

Comments

@alexsnaps
Copy link
Member

If during a flush an error occurs that has Limitador flip the partitioned flag, all these pending writes are dropped on the floor.
Additionally, a timeout will probably occur on large enough batches... we'd be better off using a different timeout for these updates
@alexsnaps alexsnaps added the kind/bug Something isn't working label Apr 24, 2024
@alexsnaps alexsnaps moved this to Todo in Kuadrant Apr 24, 2024
@alexsnaps alexsnaps mentioned this issue May 9, 2024
Merged
@alexsnaps alexsnaps linked a pull request May 9, 2024 that will close this issue
Revert on transient redis error #319
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Kuadrant May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert on transient redis error Kuadrant/limitador
1 participant
@alexsnaps