Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dns record orphan alert #862

Merged
merged 4 commits into from
Sep 24, 2024
Merged

add dns record orphan alert #862

merged 4 commits into from
Sep 24, 2024

Conversation

maleck13
Copy link
Collaborator

@maleck13 maleck13 commented Sep 17, 2024

Verification:

@maleck13
Copy link
Collaborator Author

@david-martin @R-Lawton

@maleck13 maleck13 force-pushed the sample-orphan-alert-gh-202 branch 4 times, most recently from a7621e6 to da2022a Compare September 20, 2024 10:39
Makefile Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.61%. Comparing base (ece13e8) to head (a7f8cdb).
Report is 188 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
- Coverage   80.20%   78.61%   -1.60%     
==========================================
  Files          64       91      +27     
  Lines        4492     7046    +2554     
==========================================
+ Hits         3603     5539    +1936     
- Misses        600     1092     +492     
- Partials      289      415     +126     
Flag Coverage Δ
bare-k8s-integration 5.11% <ø> (?)
controllers-integration 70.64% <ø> (?)
envoygateway-integration 46.53% <ø> (?)
gatewayapi-integration 10.61% <ø> (?)
integration ?
istio-integration 50.42% <ø> (?)
unit 27.75% <ø> (-2.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 38.46% <0.00%> (-32.97%) ⬇️
api/v1beta2 (u) 74.10% <63.82%> (-17.33%) ⬇️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 70.95% <ø> (-2.96%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 84.26% <ø> (+4.81%) ⬆️
controllers (i) 80.43% <80.17%> (+3.63%) ⬆️

see 42 files with indirect coverage changes

@maleck13 maleck13 force-pushed the sample-orphan-alert-gh-202 branch 2 times, most recently from e775412 to c9fd9a1 Compare September 20, 2024 11:33
@maleck13 maleck13 changed the title add dns record missing alert add dns record orphan alert Sep 20, 2024
Signed-off-by: craig <[email protected]>

add orphan record mitigation doc

fix lint

improve alert query
@maleck13 maleck13 force-pushed the sample-orphan-alert-gh-202 branch from c9fd9a1 to 54222b4 Compare September 20, 2024 13:33
@david-martin
Copy link
Member

I'm seeing a vendoring issue locally when running make local-setup.
I'll have to try figure this out before I can try out the steps.

/Users/davidmartin/work/kuadrant-operator/bin/controller-gen crd paths="./api/v1alpha1;./api/v1beta1;./api/v1beta2" output:crd:artifacts:config=config/crd/bases
Error: load packages in root "/Users/davidmartin/work/kuadrant-operator/api/v1alpha1": err: exit status 1: stderr: go: inconsistent vendoring in /Users/davidmartin/work/kuadrant-operator:
	github.com/cert-manager/[email protected]: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
....
....lots of stack
....
run `controller-gen crd paths=./api/v1alpha1;./api/v1beta1;./api/v1beta2 output:crd:artifacts:config=config/crd/bases -w` to see all available markers, or `controller-gen crd paths=./api/v1alpha1;./api/v1beta1;./api/v1beta2 output:crd:artifacts:config=config/crd/bases -h` for usage
make[6]: *** [manifests] Error 1
make[5]: *** [k8s-env-setup] Error 2
make[4]: *** [gatewayapi-env-setup] Error 2
make[3]: *** [istio-env-setup] Error 2
make[2]: *** [env-setup] Error 2
make[1]: *** [local-env-setup] Error 2
make: *** [local-setup] Error 2
go version
go version go1.22.5 darwin/amd64

Makefile Show resolved Hide resolved
@maleck13 maleck13 merged commit fbc1021 into main Sep 24, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants