Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all occurrences of proprietary derived code #41

Open
BomBardyGamer opened this issue Jun 18, 2021 · 2 comments
Open

Replace all occurrences of proprietary derived code #41

BomBardyGamer opened this issue Jun 18, 2021 · 2 comments

Comments

@BomBardyGamer
Copy link
Member

BomBardyGamer commented Jun 18, 2021

Description

Krypton has taken a decent amount of code from other projects, and while most of this code is fine, some of it, however, is not. One of the projects that some code has been stolen from is the vanilla server, and deriving code from the vanilla server in this way goes against the open-source nature of the project, as well as putting the project at risk of potential legal trouble in the future (though I believe this is highly unlikely).

As such, I will be working to replace all occurrences of proprietary derived code in the project. The following table shows the location of the infringing code, and the location of the original material:

Infringing code location Original code location
org.kryptonmc.krypton.util.noise net.minecraft.world.level.levelgen.synth
org.kryptonmc.krypton.util.random net.minecraft.world.level.levelgen
org.kryptonmc.krypton.world.biome net.minecraft.world.level.biome and net.minecraft.world.level.newbiome
org.kryptonmc.krypton.world.data net.minecraft.world.level.storage
org.kryptonmc.krypton.world.generation net.minecraft.world.level.levelgen
org.kryptonmc.krypton.world.region net.minecraft.world.level.chunk.storage
@BomBardyGamer BomBardyGamer added this to the Stable release milestone Jun 18, 2021
@BomBardyGamer BomBardyGamer self-assigned this Jun 18, 2021
@BomBardyGamer BomBardyGamer changed the title Replace all occurences of proprietary derived code Replace all occurrences of proprietary derived code Jun 18, 2021
@BomBardyGamer
Copy link
Member Author

I closed this because at the time, I was not prepared or inclined to do this. However, I realise that this is a necessity to secure the future of this project, so I am reopening this.

@BomBardyGamer
Copy link
Member Author

This is really, really bad, and really, really needs to go. I've neglected this in the past as I didn't really know what to replace it with, but that's a foolish decision that is not going to be repeated.

@BomBardyGamer BomBardyGamer moved this to Todo in Krypton Dec 25, 2022
@BomBardyGamer BomBardyGamer moved this from Todo to In Progress in Krypton Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

1 participant