Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Is the KRibbon RTL compliant #1569

Closed
PWagner1 opened this issue Jun 23, 2024 · 9 comments
Closed

[Question]: Is the KRibbon RTL compliant #1569

PWagner1 opened this issue Jun 23, 2024 · 9 comments
Labels
awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. question Further information is requested superseded Another issue has superseded this one.

Comments

@PWagner1
Copy link
Contributor

Following on from #343, has anyone tested the KRibbon to make sure that it is RTL compliant?

@PWagner1 PWagner1 added question Further information is requested awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. labels Jun 23, 2024
@giduac
Copy link
Contributor

giduac commented Jun 24, 2024

Hi @Wagnerp & @Smurf-IV

Are all (whole TK) controls RTL compliant or is there more work todo to reach this goal?

If there's still a lot of work to do on this than it might be better to turn it into a project and do good inventory and plan before starting off...

@PWagner1
Copy link
Contributor Author

Hi @Wagnerp & @Smurf-IV

Are all (whole TK) controls RTL compliant or is there more work todo to reach this goal?

If there's still a lot of work to do on this than it might be better to turn it into a project and do good inventory and plan before starting off...

Hi @giduac

This is what I'm thinking. It would be good to get someone who uses RTL to look into this.

@PWagner1
Copy link
Contributor Author

Apparently this is how a ribbon should look in RTL

image

image

@PWagner1
Copy link
Contributor Author

PWagner1 commented Jun 24, 2024

Current situation using nightly >= .176

RTLBug

@giduac
Copy link
Contributor

giduac commented Jun 24, 2024

@Wagnerp

Is the ribbon the only control that needs looking into RTL or are there others?

Like said earlier it can be a good way to go about it and take it on as whole to make RTL a complete feature of KT instead of reacting to tickets. So a bit more of a proactive instead of a reactive approach.

@PWagner1
Copy link
Contributor Author

@Wagnerp

Is the ribbon the only control that needs looking into RTL or are there others?

Like said earlier it can be a good way to go about it and take it on as whole to make RTL a complete feature of KT instead of reacting to tickets. So a bit more of a proactive instead of a reactive approach.

@giduac

Possibly the docking, workspace etc as well.

@PWagner1
Copy link
Contributor Author

Can confirm that navigator controls work as expected

@giduac
Copy link
Contributor

giduac commented Jun 24, 2024

@PWagner1 PWagner1 added the superseded Another issue has superseded this one. label Jul 4, 2024
@PWagner1
Copy link
Contributor Author

PWagner1 commented Jul 4, 2024

Superseded by #1570

@PWagner1 PWagner1 closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. question Further information is requested superseded Another issue has superseded this one.
Projects
None yet
Development

No branches or pull requests

2 participants