Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserveThenGetNamePaths import combines bundles #20

Open
dckc opened this issue Sep 23, 2023 · 0 comments
Open

reserveThenGetNamePaths import combines bundles #20

dckc opened this issue Sep 23, 2023 · 0 comments
Assignees
@WietzeSlagman
Labels
enhancement New feature or request

Comments

@dckc
Copy link
Contributor

dckc commented Sep 23, 2023

We changed one line in start-kread-proposal.js and 3 of the 4 bundles changed.

This import seems awkward:

KREAd/agoric/contract/src/proposal/kread-committee-proposal.js

Line 3 in 875f5de

import { reserveThenGetNamePaths } from './start-kread-proposal.js';

suggestion: move the two reserveThen... to a new module/file.

cc @turadg @Chris-Hibbert @WietzeSlagman
@MangoDream1 MangoDream1 added the enhancement New feature or request label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WietzeSlagman WietzeSlagman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dckc @WietzeSlagman @MangoDream1