Prepend KEEP ID to documents to keep them sorted #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm going to break link formats anyway in the following commits. According to https://github.com/Kotlin/KEEP/graphs/traffic this document isn't that popular
Pros: - Files are nicely sorted. Now it's easier to take a look at the latest proposals Cons: - Links are broken because of this commit (I will add redirects to popular proposals in the next commit)
The proposals are popular according to GH stats: https://github.com/Kotlin/KEEP/graphs/traffic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsoutput to see how it looksI changed the names only to realize that links will break :(
Well, links between pull requests and documents in
masterbreak each time we merge pull requests@zarechenskiy it's up to you to decide whether to accept this PR. Feel free to decline the PR without any reasons
My opinion is the following: I think that the current system is already broken (links between blobs in PRs and blobs in
masterare different anyway), so I think it's ok to break links inmaster. Links are broken this way or another, but at least we can have the documents nicely sorted, to skim them