Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Некорректный тест, lesson 8 #2

Open
ghost opened this issue Oct 19, 2020 · 0 comments
Open

Некорректный тест, lesson 8 #2

ghost opened this issue Oct 19, 2020 · 0 comments

Comments

@ghost
Copy link

ghost commented Oct 19, 2020

Некорректный метод (lesson8.task1.Tests#approxEquals) проверки двух отрезков (экземпляров класса lesson8.task1.Geometry.Segment) на равенство.
Как есть: возврат true, если одновременно начало первого отрезка равно началу второго отрезка и конец первого отрезка равен концу второго отрезка, т.е. учитывается "направление" отрезка.
Как должно быть: два отрезка равны, если либо начало первого отрезка совпадает с началом второго отрезка и конец первого отрезка совпадает с концом второго отрезка, либо начало первого отрезка совпадает с концом второго и конец первого отрезка совпадает с началом второго отрезка.

Некорректный метод approxEquals вызывается методом assertApproxEquals для тестирования метода diameter из lesson8.task1.Geometry.

invalid
Iksburg added a commit to Iksburg/KotlinAsFirst2020 that referenced this issue Oct 23, 2020
@Iksburg
All errors are fixed (Attempt Kotlin-Polytech#2).
7d7e1ad
Iksburg added a commit to Iksburg/KotlinAsFirst2020 that referenced this issue Oct 30, 2020
@Iksburg
5 tasks from lesson 5 are done (Attempt Kotlin-Polytech#2).
03cb38e
Iksburg added a commit to Iksburg/KotlinAsFirst2020 that referenced this issue Nov 3, 2020
@Iksburg
1 task from lesson 7 are done (Attempt Kotlin-Polytech#2).
6f5888b
Iksburg added a commit to Iksburg/KotlinAsFirst2020 that referenced this issue Nov 9, 2020
@Iksburg
Task plusMinus are fixed (Attempt Kotlin-Polytech#2).
a795f53
Iksburg added a commit to Iksburg/KotlinAsFirst2020 that referenced this issue Nov 14, 2020
@Iksburg
Bad decision of task centerFile (Attempt Kotlin-Polytech#2).
d982f0d
Iksburg added a commit to Iksburg/KotlinAsFirst2020 that referenced this issue Nov 14, 2020
@Iksburg
Task centerFile from lesson 7 are fixed (Attempt Kotlin-Polytech#2).
b5cfcce
argraur pushed a commit to argraur/KotlinAsFirst2020 that referenced this issue Feb 15, 2022
@vladdenisov
try to fix segmentLength Kotlin-Polytech#2
cd49017
argraur pushed a commit to argraur/KotlinAsFirst2020 that referenced this issue Feb 15, 2022
@vladdenisov
fix russian Kotlin-Polytech#2
dbbd82f
argraur added a commit to argraur/KotlinAsFirst2020 that referenced this issue Feb 15, 2022
@argraur
lesson7: fix random error Kotlin-Polytech#2
05e3ded
s1ckoleg pushed a commit to s1ckoleg/KotlinAsFirst2020 that referenced this issue Mar 1, 2022
@wishyoudie
Lesson 7 markdownToHtmlSimple solved
d76e102 
Lesson 9 fifteenGame commit Kotlin-Polytech#2:
Added some more matrices methods, changed fun a bit.
vladdenisov added a commit to vladdenisov/KotlinAsFirst2020 that referenced this issue Mar 3, 2022
@vladdenisov
try to fix segmentLength Kotlin-Polytech#2
709fbf6
vladdenisov added a commit to vladdenisov/KotlinAsFirst2020 that referenced this issue Mar 3, 2022
@vladdenisov
fix russian Kotlin-Polytech#2
2bb9f17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants