fix(konnect): fix EnqueueRequestsFromMapFunc predicates for konnect entities #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
fix-EnqueueRequestsFromMapFunc-predicates
branch
4 times, most recently
from
01cbf49 to
a169182
Compare
pmalek
force-pushed
the
fix-EnqueueRequestsFromMapFunc-predicates
branch
from
a169182 to
043a459
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes an issue with missing
EnqueueRequestsFromMapFuncpredicates for types that are shared between KGO and KIC.When some objects change, we need to check if that object should trigger the dependents to be enqueued. For instance
KongConsumerGroupchanges should only trigger a reconciliation forKongConsumers in that group then the group is bound to aKonnectGatewayControlPlane.Otherwise we assume that's a group reconciled by KIC.
Which issue this PR fixes
Fixes #939
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes