Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Konnect entities: Gateway Control Plane Group - Control Plane Group Memberships #449

Closed
1 task
Tracked by #370
pmalek opened this issue Jul 31, 2024 · 4 comments · Fixed by #697
Closed
1 task
Tracked by #370

Konnect entities: Gateway Control Plane Group - Control Plane Group Memberships #449

pmalek opened this issue Jul 31, 2024 · 4 comments · Fixed by #697
Assignees
Milestone

Comments

@pmalek
Copy link
Member

pmalek commented Jul 31, 2024

Problem statement

Introduce ControlPlane group membership for KonnectControlPlane.

For details see https://docs.google.com/document/d/1TxW2ovqPRm-w1td1e_V0CyaET4lpiEBCJ7hiYMZJqng/edit#heading=h.i2q1r7wb62uu

Proposed solution

  • Introduce ControlPlane group membership for KonnectControlPlane.

Prerequisites

Acceptance criteria

  • KGO can set ControlPlane group membership on Konnect's ControlPlanes.
@pmalek
Copy link
Member Author

pmalek commented Sep 10, 2024

Blocked by lacking KHCP changes (details in linked slack thread).

@pmalek
Copy link
Member Author

pmalek commented Sep 17, 2024

KHCP ticket in progress: https://konghq.atlassian.net/browse/KHCP-13304

@pmalek
Copy link
Member Author

pmalek commented Sep 24, 2024

https://github.com/Kong/khcp/pull/8011 implemented support for empty arrays.

There's an investigation ongoing checking why allowing empty arrays doesn't work :

curl  -H 'Content-Type: application/json' -H "Authorization: Bearer ${KONNECT_TOKEN}" -XPUT https://eu.api.konghq.tech/v2/control-planes/xxxxxxxxxxxxxx/group-memberships --data '{"members":[]}'
{"status":400,"title":"Invalid Request","instance":"kong:trace:15106412113331495426","detail":"Invalid Parameters","invalid_parameters":[{"field":"members","rule":"array_not_empty","choices":[],"reason":"members should not be empty"}]}%

@pmalek
Copy link
Member Author

pmalek commented Sep 26, 2024

This has now been fixed https://github.com/Kong/khcp/pull/8014 and deployed to dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant