Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parser - simplified with a tokenizer pass #114

Merged
merged 6 commits into from
Dec 30, 2023
Merged

New parser - simplified with a tokenizer pass #114

merged 6 commits into from
Dec 30, 2023

Conversation

Kolaru
Copy link
Owner

@Kolaru Kolaru commented Dec 30, 2023

Fix #100

The new parser is easier to understand and should help with issues that require to modify it.

This is breaking because know spaces are always kept, they are discarded in math mode during layouting.

Also $ .. $ are now parsed as a :inline_math TeXExpr, opening the road for proper line breaks.

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (cad0b7f) 81.02% compared to head (06b8643) 79.49%.

Files Patch % Lines
src/parser/parser.jl 84.04% 15 Missing ⚠️
src/engine/layout.jl 69.23% 4 Missing ⚠️
src/parser/commands_registration.jl 98.11% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   81.02%   79.49%   -1.53%     
==========================================
  Files          10       10              
  Lines         585      556      -29     
==========================================
- Hits          474      442      -32     
- Misses        111      114       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kolaru Kolaru merged commit c8cb679 into master Dec 30, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate tokenization from the building of the TeXExpr
2 participants