Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SceneDelegate based application #34

Open
yasheedv opened this issue Apr 27, 2022 · 4 comments
Open

Support SceneDelegate based application #34

yasheedv opened this issue Apr 27, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@yasheedv
Copy link

I have created a sample application with iOS 13 target. It's using SceneDelegate.
PIPKit.show(with: PIPViewController()) not showing the PIPViewController
@yasheedv
Copy link
Author

It's working if I change PIPKitWindow allocation like below under PIPKit class line number 73

let newWindow: PIPKitWindow
if let currentWindowScene = UIApplication.shared.connectedScenes.first as? UIWindowScene {
newWindow = PIPKitWindow(windowScene: currentWindowScene)
} else {
newWindow = PIPKitWindow() }

@Kofktu
Copy link
Owner

Kofktu commented May 3, 2022

Can I request a PR?

Kofktu added a commit that referenced this issue Aug 15, 2022
@Kofktu
[#34] Support SceneDelegate based application
ef4ad46
@Kofktu
Copy link
Owner

Kofktu commented Aug 15, 2022

@yasheedv
Could you test it with that feature/issue-34-support_scenedelegate branch?

@Kofktu Kofktu added the enhancement New feature or request label Aug 15, 2022
@Pobe16
Copy link

Pobe16 commented Oct 19, 2022

I tested it today and it is working very good. Please PR

@junbok97 junbok97 mentioned this issue Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kofktu @Pobe16 @yasheedv