You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we return false (or something similar) to notify error(s). It leads to bad DX. However, in some cases native exceptions are used but they're too general. Specific exceptions would be better, we should improve this for v1.0.
Proposal
Introduce a generic exception for Adapter (named StorageFailure)
Introduce a generic exception for Filesystem (named FilesystemFailure)
The reason for two distinct exceptions goes as is: Filesystem has a compatibility layer that mimics some behaviors based on the minimal subset of functionality offered by Adapter interface.
Also, it would be great to introduce more specific exceptions like FileNotFound.
We need to remove support of php v5.6 if we want to properly handle errors for Local adapter. Also OpenCloud adapter shouldn't be fixed for now: it's based on an outdated SDK.
Currently we return false (or something similar) to notify error(s). It leads to bad DX. However, in some cases native exceptions are used but they're too general. Specific exceptions would be better, we should improve this for v1.0.
Proposal
StorageFailure
)FilesystemFailure
)The reason for two distinct exceptions goes as is: Filesystem has a compatibility layer that mimics some behaviors based on the minimal subset of functionality offered by
Adapter
interface.Also, it would be great to introduce more specific exceptions like
FileNotFound
.Todo
The text was updated successfully, but these errors were encountered: