You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The shouldUpgrade function passed to NIOWebSocket.WebSocketUpgrader is expected to return an EventLoopFuture<HTTPHeaders?> to indicate a successful or failed upgrade. On a successful upgrade, we return eventLoop.makeSucceededFuture(httpHeaders). But on a failed upgrade (may be because the requested websocket service doesn't exist), it may make sense to return a eventLoop.makeFailedFuture(<error>). The questions here are:
a. Does the NIOWebSocket.WebSocketUpgrader handle an error wrapped in a failed future?
b. What error value do we return?
The
shouldUpgrade
function passed toNIOWebSocket.WebSocketUpgrader
is expected to return anEventLoopFuture<HTTPHeaders?>
to indicate a successful or failed upgrade. On a successful upgrade, we returneventLoop.makeSucceededFuture(httpHeaders)
. But on a failed upgrade (may be because the requested websocket service doesn't exist), it may make sense to return aeventLoop.makeFailedFuture(<error>)
. The questions here are:a. Does the
NIOWebSocket.WebSocketUpgrader
handle an error wrapped in a failed future?b. What error value do we return?
cc @ianpartridge
The text was updated successfully, but these errors were encountered: