Added reset/load/save settings #65
Open
+111
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added reset/load/save settings Settings page: - Added reset settings button (resets to default) - Added save/load custom settings button (stored in localStorage.settings) Save/load buttons are hidden when localStorage is no accessible Load button is hidden when there is nothing to load loadSettings now loads saved custom settings by default if all settings are default (if the user likes the default settings, then they can save default settings as custom settings so they aren't forced off the default settings or they can simply not save the custom settings)
Changed saveSettingsLocalStorage to get all the current settings, then delete the ones _not_ in a list of ones we want. Changed loadSettingsLocalStorage to handle missing (default) `settings.data` data-set. Changed reset settings to only get current settings then delete only settings to reset
Moved list of names of settings that are saved in localStorage to its own array called `LOCALSTORAGE_SAVED_SETTINGS` (updated events accordingly)
|
Any updates on this? It probably needs a new review but is there any reason not to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reset/load/save settings
Settings page:
Save/load buttons are hidden when localStorage is no accessible
Load button is hidden when there is nothing to load
loadSettings now loads saved custom settings by default if all settings are default (if the user likes the default settings, then they can save default settings as custom settings so they aren't forced off the default settings or they can simply not save the custom settings)