Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added @ media print style to css #149

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Ma124
Copy link

@Ma124 Ma124 commented May 31, 2019

Before:
before @ media print

After: (empty circles are shown when no modules are selected)
image

@mxdanger
Copy link

mxdanger commented Jun 4, 2019

Here are my implementations of it. Not finished yet but you can test it here.

White theme normally. Screen Shot 2019-06-03 at 7 20 01 PM

White theme while printing. Screen Shot 2019-06-03 at 7 18 06 PM

Default theme normally. Screen Shot 2019-06-03 at 7 21 41 PM

Default theme while printing. Screen Shot 2019-06-03 at 7 25 12 PM

@Ma124
Copy link
Author

Ma124 commented Jun 4, 2019

@mxdanger shouldn't it be the white theme for printing automatically and you don't need the link icon in the print view, do you?

@Ma124
Copy link
Author

Ma124 commented Jun 4, 2019

But I really like what you've done so far

@mxdanger
Copy link

mxdanger commented Jun 4, 2019

@Ma124 I had to modify the JS so that the total power output touched the right edge so the table wouldn’t look weird. I might find a better way to do it later. Anyways, glad you found it nice.

@mxdanger
Copy link

mxdanger commented Jun 4, 2019

It could be in white theme automatically but some people might want to a dark colored printout. Might as well give them a choice, but at the same time it might be good to have it be white automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants