Geometry check

[easyw]

Hi,
if FreeCAD (release 0.17 > 12703) can be included in travis checking chain, it would be possible to check geometry of STEP models in an automatic way:

1. modify the following command checking script to give positive or negative results to travis
   checkBOPnoGui.py.zip

2. launch the following command to run the checking in command mode (without the need of a gui)
   freecadcmd checkBOPnoGui.py "full_path_to_STEP_file/resistor-wrong-BOP.step"
   or in linux
   freecadcmd-daily checkBOPnoGui.py "full_path_to_STEP_file/resistor-wrong-BOP.step"
   Here a wrong STEP model to test:
   resistor-wrong-BOP.zip

It would be possible then to put some checking at the PR template like:

• is your 3D model made in a mechanical modeler?
• have you submitted the source of the model (source file or script)?
• have you submitted both STEP in scale 1:1 and wrl in scale 1:2.54?
• are your 3D models aligned to the KiCad footprint?
• is your WRL model using material properties?

[SchrodingersGat]

Thanks! I have added a PR template based on your points above. I'll look into the FreeCad script soon

[easyw]

thx...
I forgot to add an other useful point:

• have you added a screenshot of the 3D model(s) over the footprint(s) in KiCad in the comments of the PR?

[poeschlr]

I think this is a related issue: KiCad/kicad-library#1546 (comment)

[Shackmeister]

Perhaps a Travis check if the model is referenced anywhere?

[SchrodingersGat]

Do you mean referenced by a footprint?

[Shackmeister]

@easyw
just noticed this issue again :)
do you believe the check could be implemented relatively painless into Travis?

[easyw]

No, unfortunately geometry check does not give a clear result. There could be many false positive results. I wouldn't add any check like this on Travis.