-
Notifications
You must be signed in to change notification settings - Fork 714
Add AC/DC converters Recom RAC20-xxSK and RAC20-xxDK #2265
Conversation
Hi @Werni2A , thank you for your contribution. |
Hi @aris-kimi , thanks for taking a look at the footprint. I think this was my first contribution to the library. From my current point of view there are a few aspects that I want to change. The most important one is that this kind of packages are quite common therefore I will try to write a generator script for it. Until then I mark this PR as WIP. |
@aris-kimi I updated the footprint. It would be great if you could take a look at it :) This time created with footprint-generator |
Semms like you were faster with linking the according generator ;) |
(fp_text user "" (at -3 0) (layer F.SilkS) | ||
(effects (font (size 1 1) (thickness 0.15))) | ||
) | ||
(model ${KISYS3DMOD}/Converter_DCDC.3dshapes/Converter_ACDC_Recom_RAC20-xxDK_THT.wrl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @evanshultz and @myfreescalewebpage , this 3D path is wrong, because the script used was about DC/DC converters, can AC/DC added at the scripts?
If not i will advice to manually edit..Same for the second part.
I haven't reviewed them yet..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion it would be great to make the script more generic e.g. passing the library as a parameter. Also passing the drill diameter without any pad information would be nice as this dimensions can be calculated via the IPC standard and most datasheets don't specify the pads.
While I'm at working on those converters, I can add the 3dfootprint for this RAC20 series. Just, I don't really know if I put the 3dimages in my current KiCad/kicad-packages3D#721 PR |
@Franck78 great that you add 3D models, I personally have no experience in creating those models. 👍 I think it's best to create a new PR and link it to this one. When everything is in only one PR it slows the whole process down as every part has to be checked before it can be merged. But I'm no librarian so that's just the impression I got. |
have you tried the 3D on the footprint just to confirm it is good ? Yes, with 5 or more repo to follow, it is rapidly becoming messy. |
on the other side, the white line must follow the body, no space, no hide. |
Closing/opening to refresh the Travis test. |
@Werni2A starting the review here. For both footprints:
Joel |
Hi @myfreescalewebpage thanks for taking a look at this PR and sorry for the work. The Converter_DCDC generator is not very well suited for this footprints. As soon as pointhi/kicad-footprint-generator#624 is merged I wanted to rework/replace Converter_DCDC with a more generic DIP package generator. Until someone is terribly in need for this footprint I would like to keep it on hold until I wrote the generator. |
As you wish, but there are only few comments on the footprint and KiCad/kicad-symbols#2692 is waiting for this to be merged, so I think it can be very nice to finish manually and update later with scripted version. |
@myfreescalewebpage your comment is a good point. I updated the footprints manually. There were also some empty "user text" in the footprint that I removed. |
Thanks, at the moment the footprints can be merged. Up to you for a very nice converter script (you're welcome to do that !!) |
Adds the 20W AC/DC converter series RAC20.
https://recom-power.com/pdf/Powerline_AC-DC/RAC20-K.pdf
FP geometry
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)