cmake: Add a function to setup all build targets with the same strictness #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophe-lunarg
force-pushed
the
cmake-w4-msvc
branch
from
34f6b1a to
4b39429
Compare
|
juan-lunarg
reviewed
Sep 6, 2023
christophe-lunarg
force-pushed
the
cmake-w4-msvc
branch
from
52c518e to
f2e91ac
Compare
christophe-lunarg
changed the title
christophe-lunarg
force-pushed
the
cmake-w4-msvc
branch
2 times, most recently
from
df24160 to
fbcb967
Compare
juan-lunarg
approved these changes
Sep 7, 2023
juan-lunarg
reviewed
Sep 7, 2023
| @@ -101,6 +101,47 @@ if (UPDATE_DEPS) | |||
| include("${UPDATE_DEPS_DIR}/helper.cmake") | |||
| endif() | |||
| endif() | |||
|
|
|||
| # Configure compiler build options common to all targets | |||
| function(lunarg_target_compiler_configurations TARGET_NAME WERROR_OPTION) | |||
There was a problem hiding this comment.
What would be ideal is if we could actually share this code elegantly with the other repos that consume the utility libraries.
I think this can be done. I'll wait until this gets merged though.
There was a problem hiding this comment.
Yes that's what I was thinking!
christophe-lunarg
force-pushed
the
cmake-w4-msvc
branch
from
049e33c to
7bd23db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Question: Here I am using
add_compile_optionsdoes it affect other target that would add this repository to it's project?Using
find_packageandadd_subdirctory?I am using
add_compile_optionsbecause this is was used for/WX.