Remove unnecessary std filesystem #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Who are the users? VUL will not compile without a C++17 compiler. |
juan-lunarg
previously approved these changes
Nov 6, 2023
|
std::filesystem was added to support the Chromium windows build as it can handle the native windows unicode path encoding. I think reverting it back to std::string will break them again |
|
Erm, yes this doesn't seem right to me, specifically "VUL will not compile without a C++17 compiler." unless if the idea is to support older compilers for specific reasons that are not mentioned here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users of VUL don't have support for std::filesystem, and there is no real reason that std::filesystem is used here